Replace hardcoded slug check with account-level setting#63
Open
bellisabell wants to merge 1 commit intomainfrom
Open
Replace hardcoded slug check with account-level setting#63bellisabell wants to merge 1 commit intomainfrom
bellisabell wants to merge 1 commit intomainfrom
Conversation
- Add sync_to_ghost boolean column to accounts table - Replace hardcoded 'philipithomas' slug check with @account.sync_to_ghost - New accounts default to sync_to_ghost: false - Existing account can be updated via migration or Rails console Closes #26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the hard-coded account slug check in SubscriptionVerificationsController.
Changes
sync_to_ghostboolean column to the accounts table (defaults to false)@account.slug == 'philipithomas'check with@account.sync_to_ghostMigration Notes
After running migrations, enable Ghost syncing for existing accounts via Rails console:
Closes #26