Open
Conversation
fbi.com is a real domain (Federal Bureau of Investigation), not a localhost testing domain like lvh.me or fuf.me. Its presence in this list was incorrect and could cause unexpected behavior. Closes #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
fbi.comfrom theLOCALHOST_DOMAINSarray inapp/models/domain.rb.Problem
fbi.comis a real domain (Federal Bureau of Investigation), not a localhost testing domain. The other entries (lvh.me,fuf.me) are legitimate localhost testing domains that resolve to 127.0.0.1, butfbi.comis an actual production website.Solution
Simply remove
fbi.comfrom the array. The remaining two localhost domains are sufficient for development purposes.Closes #25