Skip to content

Fix: rescue StandardError instead of Exception in PublishPostJob #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bellisabell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: rescue StandardError instead of Exception in PublishPostJob #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/jobs/publish_post_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def perform(*posts) # rubocop:disable Metrics/MethodLength

post.account.subscriptions.active.find_each do |subscription|
AccountMailer.new_post(post, subscription).deliver_now
rescue Exception => e # rubocop:disable Lint/RescueException
rescue StandardError => e
Rails.logger.error "Error sending post to #{subscription.email_address.email}: #{e}"
# For AWS SES bounces and complaints, we may want to add specific error handling later
end
Expand Down