Security: Fix SSRF vulnerability in attach_photo_from_url#56
Open
bellisabell wants to merge 1 commit intomainfrom
Open
Security: Fix SSRF vulnerability in attach_photo_from_url#56bellisabell wants to merge 1 commit intomainfrom
bellisabell wants to merge 1 commit intomainfrom
Conversation
…ver_from_url - Validate URL scheme (whitelist http/https only) - Add timeout constraints (10 second open/read timeout) - Validate content-type (only allow image types) - Validate file size (max 10MB) - Handle redirects safely (up to 3, with scheme validation) - Replace URI.open with Net::HTTP for better control Closes #16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical SSRF vulnerability in
attach_photo_from_urlandattach_cover_from_urlmethods whereURI.open(url)was used without any validation.Changes
http://andhttps://URLs (blocksfile://,ftp://, etc.)Net::HTTPinstead ofURI.openimage/jpeg,image/png,image/gif,image/webp)Security Impact
Previously an attacker could:
http://localhost:...orhttp://169.254.169.254/...(cloud metadata)file:///etc/passwdNow all these vectors are blocked.
Closes #16