This repository was archived by the owner on Dec 4, 2018. It is now read-only.
support default manifest path and application name like cf push does#41
Open
cmloegcmluin wants to merge 2 commits intocontraband:masterfrom
Open
support default manifest path and application name like cf push does#41cmloegcmluin wants to merge 2 commits intocontraband:masterfrom
cf push does#41cmloegcmluin wants to merge 2 commits intocontraband:masterfrom
Conversation
- CF CLI properly defaults this - update test to reflect that CF CLI also properly defaults the app path flag Signed-off-by: Douglas Blumeyer <dblumeyer@pivotal.io>
… CLI). - Assumes app name does not start with '-'. - Assumes manifest is well-formed. - Uses first app in manifest if multiple are found (like CF CLI). - If name provided, and name found in manifest, name provided takes precedence (like CF CLI). - See contraband#32 Signed-off-by: Robert Gravina <rgravina@pivotal.io>
Contributor
|
Thank you for submitting this! I'm sorry for the delay. I'll try and get around to reviewing it soon. |
|
@xoebus Any update on this? |
Contributor
|
Hi @zachberger, sorry I haven't had a chance to get to this yet. Unfortunately I'm swamped for the next few weeks too. I like the feature and would probably merge it but don't have time to look into the code in detail just yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the autopilot plugin and think it's great, but thought it would be greater if we didn't need to specify the app name or manifest path if:
That way,
cf pushcould be swapped out forzero-downtime-pushwith no changes.We are Pivots from Pivotal Tokyo on the beach and are new to Go, so we may not have written the most idiomatic code. We also used some CF CLI internals; it seemed appropriate but again not quite sure. Happy for any feedback.
Douglas Blumeyer & Robert Gravina