Fix use of self inside default trait method implementation body #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in
#[cgp_component]when the consumer trait contains default method implementation.Previously, this would cause compile errors in the generated code, as the provider trait would contain the default implementation that refers to
self.Example
With the fix, we can now write trait implementations such as follows:
which would correctly generate the following provider trait:
Previously, the following would have been generated, causing compile error with the dangling reference to
self: