feat(types): changeFieldControl builtin overload#930
Open
AndrewLeedham wants to merge 2 commits intocontentful:mainfrom
Open
feat(types): changeFieldControl builtin overload#930AndrewLeedham wants to merge 2 commits intocontentful:mainfrom
AndrewLeedham wants to merge 2 commits intocontentful:mainfrom
Conversation
|
This PR would be extremely useful when using Typescript migrations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds overloads for changeFieldControl so
widgetIdcan be auto-completed when using the'builtin'widgetNamespace.Description
Adds 2 overloads one for
'builtin'and the other for'extension' | 'app'which scope thewidgetIdfield to either be one of the built in Contentful widgets from https://www.contentful.com/developers/docs/extensibility/app-framework/editor-interfaces/ or any string.Motivation and Context
Makes writing migration scripts quicker without needing to lookup the docs for the IDs of builtin widgets. Essentially just a DX improvement.
Screenshots (if appropriate):