fix: allow null value for regexp flags in validation interface#1541
Open
adamiscoding wants to merge 1 commit intocontentful:mainfrom
Open
fix: allow null value for regexp flags in validation interface#1541adamiscoding wants to merge 1 commit intocontentful:mainfrom
adamiscoding wants to merge 1 commit intocontentful:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creating a diff file for migration returns flags: null when no flags are set in the ui, therefore failing TS typecheck.
Joi configuration allows null as a value, so I believe type definition is lagging behind
Description
Update types definition file to match the reality.
Motivation and Context
Fixes annoying type errors on programmatically generated migration files
Screenshots (if appropriate):