Skip to content

Conversation

@diversworld
Copy link

Add metadata for vendor divers world including two modules.

@diversworld diversworld requested a review from MDevster as a code owner July 18, 2025 12:56
@@ -0,0 +1,10 @@
de:
title: Diveclub Managerr
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Diveclub Managerr
title: Diveclub Manager

de:
title: Diveclub Managerr
description: >
Module für die Verwaltung Eines Tauchclubs. Erstes Modul ist der Verleih von Equipment. Weitere folgen.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Module für die Verwaltung Eines Tauchclubs. Erstes Modul ist der Verleih von Equipment. Weitere folgen.
Module für die Verwaltung eines Tauchclubs. Erstes Modul ist der Verleih von Equipment. Weitere folgen.

en:
title: Diveclub Manager
description: >
Modules for managing a Diveclub. First Part ist equipment rental. more will follow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Modules for managing a Diveclub. First Part ist equipment rental. more will follow
Modules for managing a Diveclub. First part ist equipment rental. More will follow

@@ -0,0 +1,9 @@
en:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
en:
de:

de:
title: Diveclub Manager
description: >
Mit dem Diveclub Manager kann eine Verein seine Ausrüstung verwalten. Mitglieder können Ausrüstung ausleihen und es gibt ein Modul zur Verwaltung der TÜV Termine der Tauchgeräte.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Mit dem Diveclub Manager kann eine Verein seine Ausrüstung verwalten. Mitglieder können Ausrüstung ausleihen und es gibt ein Modul zur Verwaltung der TÜV Termine der Tauchgeräte.
Mit dem Diveclub Manager kann ein Verein seine Ausrüstung verwalten. Mitglieder können Ausrüstung ausleihen und es gibt ein Modul zur Verwaltung der TÜV Termine der Tauchgeräte.

title: Diveclub Manager
description: >
Mit dem Diveclub Manager kann eine Verein seine Ausrüstung verwalten. Mitglieder können Ausrüstung ausleihen und es gibt ein Modul zur Verwaltung der TÜV Termine der Tauchgeräte.
Eine Erweiterung um die angebotenen Kurse zu verwalten ist in Arbeit.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Eine Erweiterung um die angebotenen Kurse zu verwalten ist in Arbeit.
Eine Erweiterung, um die angebotenen Kurse zu verwalten, ist in Arbeit.

en:
title: Diveclub Manager
description: >
With the Diveclub Manager a Dicveclub kan manage the owned Eqipment of the Club. Posibility for Clubmembers to rent Equipoment. Managing of the anual check of the Tanks.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
With the Diveclub Manager a Dicveclub kan manage the owned Eqipment of the Club. Posibility for Clubmembers to rent Equipoment. Managing of the anual check of the Tanks.
With the Diveclub Manager a dive club can manage the owned eqipment of the club. Possibility for club members to rent equipment. Managing of the annual check of the tanks.

en:
title: Diveclub Manager
description: >
With the Diveclub Manager a Dicveclub kan manage the owned Eqipment of the Club. Posibility for Clubmembers to rent Equipoment. Managing of the anual check of the Tanks.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
With the Diveclub Manager a Dicveclub kan manage the owned Eqipment of the Club. Posibility for Clubmembers to rent Equipoment. Managing of the anual check of the Tanks.
With the Diveclub Manager a dive club can manage the owned equipment of the club. Possibility for club members to rent equipment. Managing of the annual check of the tanks.

title: Diveclub Manager
description: >
With the Diveclub Manager a Dicveclub kan manage the owned Eqipment of the Club. Posibility for Clubmembers to rent Equipoment. Managing of the anual check of the Tanks.
A funnctionality to plan and manage the offerd courses is in pnalnning.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A funnctionality to plan and manage the offerd courses is in pnalnning.
A functionality to plan and manage the offered courses is in the planning.

@xchs
Copy link
Collaborator

xchs commented Jul 18, 2025

@diversworld There are still some errors in the linter that need to be fixed.

Please also optimize the icons with https://jakearchibald.github.io/svgomg/

@diversworld
Copy link
Author

Made correction in the Data

Copy link
Member

@zoglo zoglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diversworld I hope that you do realize, that you are adding metadata for:

diversworld/contao-calendar-editor
diversworld/contao-diveclub-bundle

AND

pdir/diversworld/contao-calendar-editor
pdir/diversworld/contao-diveclub-bundle

hence the request for the CODEOWNER of pdir? This seems like a drag and drop issue to me, can you confirm you want to add your bundle to pdir as well?

@xchs
Copy link
Collaborator

xchs commented Jul 23, 2025

@MDevster Can you please shed some light on this matter, especially regarding the changes proposed here for pdir?

I hope that you do realize, that you are adding metadata for:

diversworld/contao-calendar-editor diversworld/contao-diveclub-bundle

AND

pdir/diversworld/contao-calendar-editor pdir/diversworld/contao-diveclub-bundle

hence the request for the CODEOWNER of pdir? This seems like a drag and drop issue to me, can you confirm you want to add your bundle to pdir as well?

@MDevster
Copy link
Collaborator

I think the pdir stuff can be removed.
We also have the Calendar Editor as RC, but we will definitely change the description. And the repo will be called pdir/contao-calendar-editor.

@diversworld
Copy link
Author

diversworld commented Jul 23, 2025

I made Contao-calendar-editor ready for Contao 5. because I needed it and I couldn't find a Contao 5 realy Version of contao-calendar-editor.

When a conto5 Version now is available I can remove my Version

@diversworld
Copy link
Author

@diversworld I hope that you do realize, that you are adding metadata for:

diversworld/contao-calendar-editor

diversworld/contao-diveclub-bundle

AND

pdir/diversworld/contao-calendar-editor

pdir/diversworld/contao-diveclub-bundle

hence the request for the CODEOWNER of pdir? This seems like a drag and drop issue to me, can you confirm you want to add your bundle to pdir as well?

Probably my mistake. I made the contao-csldndar-editor ready for contao 5. I wouldn't ad the bundle to pdir.
Yes its a drag and drop issue.

# Conflicts:
#	meta/diversworld/contao-calendar-editor/de.yml
#	meta/diversworld/contao-calendar-editor/en.yml
@xchs
Copy link
Collaborator

xchs commented Jul 28, 2025

Probably my mistake. I made the contao-csldndar-editor ready for contao 5. I wouldn't ad the bundle to pdir.
Yes its a drag and drop issue.

@diversworld So, you're gonna rework your PR and we can do another review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants