Skip to content

cmd/create: keep host supplementary groups with --group-add keep-groups #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Knogle wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −0
Open

cmd/create: keep host supplementary groups with --group-add keep-groups #1732

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d23719
cmd/create: keep host supplementary groups with --group-add keep-groups
Knogle Dec 10, 2025
ac1be04
Update src/cmd/create.go
Knogle Dec 10, 2025
f98ea18
Update src/cmd/create.go
Knogle Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/cmd/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,17 @@ func createContainer(container, image, release, authFile string, showCommandToEn
devPtsMount = []string{"--mount", "type=devpts,destination=/dev/pts"}
}

// Keep the host user's supplementary groups (eg. vboxusers) inside the
// container so that group-only device access under /dev keeps working.
// Requires Podman >= 3.2.0 where '--group-add keep-groups' was introduced
// and only makes sense for non-root (rootless) users. :contentReference[oaicite:0]{index=0}
logrus.Debug("Checking if 'podman create' supports '--group-add keep-groups'")
var keepGroups []string
if currentUser.Uid != "0" && podman.CheckVersion("3.2.0") {
logrus.Debug("'podman create' supports '--group-add keep-groups'")
keepGroups = []string{"--group-add", "keep-groups"}
}

var usernsArg string
if currentUser.Uid == "0" {
usernsArg = "host"
Expand Down Expand Up @@ -430,6 +441,9 @@ func createContainer(container, image, release, authFile string, showCommandToEn
"--dns", "none",
}

// Add '--group-add keep-groups' when available, so the container inherits
// the host user's supplementary groups (eg. vboxusers).
createArgs = append(createArgs, keepGroups...)
createArgs = append(createArgs, toolbxDelayEntryPointEnv...)
createArgs = append(createArgs, toolbxFailEntryPointEnv...)

Expand Down