Remove the old Windows installer #27859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the steps to build and publish the legacy windows installer from the GitHub release workflow. It's related to containers#27624. It also removes the deprecated `upload-win-installer.yml` workflow. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Before running machine e2e tests on Windows, the gvproxy executable was copied in `C:\Program Files\Redhat\Podman`. This is wrong because the target folder, where Podman is installed, has changed but is also useless because, after containers#27612, podman looks for gvproxy in `podman.exe` folder too. This commit removes the gvproxy copy step. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
The old setup bundle was still built and released to avoid breaking downstream projects. This commit removes it and, starting from Podman v6, only the installer that doesn't require elevated privileges will be released. This is a subtask of issue containers#27624. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Member
Author
|
@ashley-cui please have a look at the updateds to the release workflow files. In particular I have removed |
Member
|
LGTM ... @mheon as release czar, mind doing a quick review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old setup bundle was still built and released to avoid breaking downstream projects. Starting from Podman v6, only the installer that doesn't require elevated privileges will be released.
These commits:
This PR partially addresses #27624. To fully address it I will update the machine-os CI too.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?