status: drop unnecessary strtoll

[eriksjolund]

I noticed this when reading the source code.

First I was wondering if the function could return a negative number without creating an error,
but then I realised strtoll() is just some old code that can be removed.

[gemini-code-assist]

Summary of Changes

Hello @eriksjolund, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the libcrun_status_write_exec_fifo function by eliminating a redundant strtoll conversion. The previous code included an operation that was not essential for the function's intended behavior, and its removal enhances code clarity and maintains the expected return value for successful execution.

Highlights

• Code Simplification: Removed an unnecessary call to strtoll within the libcrun_status_write_exec_fifo function, simplifying its logic.
• Return Value Consistency: Replaced the strtoll return with a direct 0, ensuring a clear and consistent success indicator for the function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/libcrun/status.c
  • Removed an unused strtoll function call.
  • Updated the function to return 0 directly instead of the result of strtoll.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request correctly simplifies the libcrun_status_write_exec_fifo function by removing an unnecessary strtoll call. Given that buffer is initialized with a null byte and is not modified before the call, strtoll consistently returned 0. Replacing this with an explicit return 0; improves code readability and removes redundant logic. The change is safe and maintains the existing behavior of the function.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.