fix(lint): extend manifest list linter to manifests #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ethanbalcik <ebalcik71@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in which, even if we require support for multi-arch in our lint config, we would not catch the issue if we were passed a single-arch manifest. Fixes the issue by extending the
ContainerImageManifestListLinterand its lint rule implementations to also support being passed a manifest.For
ManifestListSupportsRequiredMediaTypes, it now supports a new config attribute calledallow-single-archwhich defaults toTrue. If true and passed a manifest, then it will just check the manifest media type. If false and passed a manifest, then it will return a lint error.For
ManifestListSupportsRequiredPlatforms, it simply checks the manifest's platform. TheContainerImageLinteralso passes in the manifest's config into this lint rule implementation when it is a single-arch manifest because that is where the platform metadata is stored.