Skip to content

Conversation

@jnovy
Copy link
Collaborator

@jnovy jnovy commented Dec 2, 2025

Replace g_assert_cmpint with proper error handling to prevent abort when signalfd read fails.

Fixes: #2348843

@jnovy jnovy requested a review from giuseppe December 2, 2025 10:03
@giuseppe
Copy link
Member

giuseppe commented Dec 2, 2025

Fixes: #2348843

this seems not correct.

Code LGTM

Replace g_assert_cmpint with proper error handling
to prevent abort when signalfd read fails.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2348843

Signed-off-by: Jindrich Novy <jnovy@redhat.com>
@jnovy
Copy link
Collaborator Author

jnovy commented Dec 2, 2025

@giuseppe It refers to https://bugzilla.redhat.com/show_bug.cgi?id=2348843 - let me reference the full URL.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnovy jnovy added the jira label Dec 2, 2025
@jnovy jnovy self-assigned this Dec 2, 2025
@jnovy jnovy merged commit b0ee2e4 into containers:main Dec 2, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants