Add an easy cleanup for tests #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portante
force-pushed
the
test-cleanup
branch
from
b1858a6 to
a199f62
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Collaborator
|
Maybe better approach would be to just use podman for image caching without any usage of Benefits:
This would need: Removal of Does it make sense? |
Contributor
Author
I'm on board. I'll take a stab at it. |
The `make clean` target now cleans up the `/tmp` area a bit. It leverages `podman pull --policy=newer` to avoid always pulling the UBI10 image instead of markers in `/tmp`. Signed-off-by: Peter Portante <peter.portante@redhat.com>
portante
force-pushed
the
test-cleanup
branch
from
a199f62 to
437e65a
Compare
Collaborator
|
LGTM, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
make cleantarget now cleans up the/tmparea a bit. It leaves around the cache of thebusyboximage to avoid fetching it too often.