Restore use of writev() system call
#609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of the sequential `write()` system calls to replace `writev()` in commit 29d17be might be simpler to understand, but can lead to unwanted CPU overhead when a high frequency of newlines exists in the data. The original bugfix for the log file corruption was the proper reset of the `iovcnt` on error. We restore the reset but always do it as part of the `writev_buffer_flush()` method which avoids "leaking" knowledge of how it works. Signed-off-by: Peter Portante <peter.portante@redhat.com>
portante
force-pushed
the
restore-writev
branch
from
6461291 to
bc69519
Compare
Adding `systemd-devel` for Fedora derivatives. Signed-off-by: Peter Portante <peter.portante@redhat.com>
portante
force-pushed
the
restore-writev
branch
from
599cbaf to
4bb9dab
Compare
Collaborator
|
LGTM, the README.md can be further amended in the following commit. Integration errors are not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the sequential
write()system calls to replacewritev()in commit 29d17be might be simpler to understand, but can lead to unwanted CPU overhead when a high frequency of newlines exists in the data. The original bugfix for the log file corruption was the proper reset of theiovcnton error. We restore the reset but always do it as part of thewritev_buffer_flush()method which avoids "leaking" knowledge of how it works.See #262 for the effects that behavioral analysis.