-
Notifications
You must be signed in to change notification settings - Fork 14
examples: Pass --hash sha256 to unified examples
#211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6afe9c2 to
5fb2fa0
Compare
|
Weird, hash computed from seems to mismatch hash computed from containers-storage |
61868ba to
3912511
Compare
|
I thought it was because of #209, but I guess not. Will need to debug it a bit more |
|
|
||
| mkdir -p /tmp/sysroot/composefs | ||
| COMPOSEFS_FSVERITY="$(cfsctl --repo /tmp/sysroot compute-id --bootable /mnt/base)" | ||
| COMPOSEFS_FSVERITY="$(cfsctl --repo /tmp/sysroot --hash sha256 compute-id --no-propagate-usr-to-root --bootable /mnt/base)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a bootable digest we should not have --no-propagate-usr-to-root - why did you add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this example was failing without this change as well; I thought maybe this was the issue
|
Okay the issue seems to be the following xattr diff 30263c30263
< /var/lib/systemd/random-seed 32 100600 1 0 0 0 1769000852.0 - \x10\x93\x81.\xa8\xae\xc7\xcbvxB9h\x86O\xca~m\xaa\xc4\xca\xfb?\xb1\xab\xda^N\xf6\xe3\xd2\xf3 - security.selinux=system_u:object_r:random_seed_t:s0 user.random-seed-creditable=1
---
> /var/lib/systemd/random-seed 32 100600 1 0 0 0 1769000852.0 - \x10\x93\x81.\xa8\xae\xc7\xcbvxB9h\x86O\xca~m\xaa\xc4\xca\xfb?\xb1\xab\xda^N\xf6\xe3\xd2\xf3 - security.selinux=system_u:object_r:random_seed_t:s0 |
|
I think the we need the xattr filter on the Oci subcommands as well |
|
Ah hah! This is an interesting and relevant use of xattrs. I think in this case though, the correct thing is to delete that file at build time. It doesn't make any sense to include the random seed in images (especially generic base images). This filtering is part of the Bigger picture I think we will need to carefully balance the "show that composefs-rs (for bootable systems) can in theory be used outside of bootc" with "don't duplicate too much work". Anyways basically I suggest |
But yes this too |
This sounds good a temp measure, but yeah we'll need the filter on all commands that do anything with |
Remove `/var/lib/systemd/random-seed` to prevent `user.` xattr diff between dumpfile created from mounted fs and oci container Also update to use fedora 43 for tests Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
3912511 to
8424c41
Compare
cgwalters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Remove
/var/lib/systemd/random-seedto preventuser.xattr diffbetween dumpfile created from mounted fs and oci container
Also update to use fedora 43 for tests