Enable offline builds and fix CMake warnings #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only needed by overlaybd-streamConv, which is not installed by CMake, and is presumably not essential. The dependency is fetched from git if it is not found system-wide, but it should be possible to perform an offline build. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Being inconsistent with the casing causes CMake to raise a big warning. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
In RapidJSON's case, we still call FetchContent_Populate because we only need the headers, but we do it in a non-deprecated way. Unfortunately, GIT_SUBMODULES is no longer respected, so gtest is fetched unnecessarily. This may be a CMake bug. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This makes offline builds possible. RapidJSON also installs a CMake config package, but it is an old style package that is unsuitable for cross-compiling. pkg-config handles this better. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Contributor
Author
|
The CI failure might be down to the erofs-utils bump. I'll check. |
Contributor
Author
|
errno 117 is |
Contributor
Author
|
Looking good now. |
2 tasks
Member
|
thanks very much~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Distributions need to be able to build offline using static sources. This is easier if we can avoid dependencies fetched by git or source them system-wide.
This also fixes all the big warnings currently raised by CMake.
Please check the following list: