re-use HostDirFromRoots for both local pulls and transfer service pulls#12661
Open
rpardini wants to merge 1 commit intocontainerd:mainfrom
Open
re-use HostDirFromRoots for both local pulls and transfer service pulls#12661rpardini wants to merge 1 commit intocontainerd:mainfrom
rpardini wants to merge 1 commit intocontainerd:mainfrom
Conversation
dosubot
bot
added
area/cri
Author
|
Realized way too late: |
rpardini
force-pushed
the
frak
branch
2 times, most recently
from
36614f7 to
e9f947e
Compare
rpardini
force-pushed
the
frak
branch
2 times, most recently
from
35ba67d to
9399317
Compare
rpardini
force-pushed
the
frak
branch
3 times, most recently
from
aeb6412 to
40a4ccb
Compare
- move (and export) `HostDirFromRoots` to core/remotes/docker/config (together with `HostDirFromRoot`) - in transfer/registry, use `filepath.SplitList()` and use shared `HostDirFromRoots` - this fixes `config_path = '/etc/containerd/certs.d:/etc/docker/certs.d'` (the default) when used with the transfer service (also default) Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HostDirFromRootsto core/remotes/docker/config (together withHostDirFromRoot)filepath.SplitList()and use sharedHostDirFromRootsconfig_path = '/etc/containerd/certs.d:/etc/docker/certs.d'(the default) when used with the transfer service (also default)