gha: Fix release workflow #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
((x++)) has a return code of 1 when x is 0, causing the job to abort. Adjust the line to ignore the return code. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Member
|
thanks |
Contributor
Author
|
Thanks again for merging. I'm not sure what happened in CI this time. It looks like you manually created the v1.4.1 release (without any assets) before the job ran. If you'd just pushed a tag, I think it would have worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This restores a line accidentally dropped in a merge conflict.
It also fixes the build job when the previous tag was X.Y.0.
((x++))has a return code of 1 whenxis 0, causing the job to abort.Please check the following list: