Skip to content

Conversation

@BigVan
Copy link
Member

@BigVan BigVan commented Jan 13, 2026

A command-line tool to attach and detach overlaybd through the
kernel's configfs interface.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@BigVan BigVan added the ok-to-test Pull request is ok to run ci test label Jan 13, 2026
@BigVan BigVan force-pushed the main branch 2 times, most recently from 4e8d39a to 1e88663 Compare January 13, 2026 09:21
  A command-line tool to attach and detach overlaybd through the
kernel's configfs interface.

Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
@BigVan BigVan merged commit 56eb65c into containerd:main Jan 13, 2026
9 checks passed
prerelease: false
files: |
releases/*/overlaybd-snapshotter*
releases/accelerated-container-image-*-vendor.tar.xz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has dropped the main part of what I just added. 😢

I believe the issue is ((patch_version++)). This exits with 1 when patch_version is 0. It's fine when it's any other number. Do this instead.

: $((patch_version++))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by the history, it looks like you dropped that line accidentally because of a merge conflict. I'll submit another PR to fix everything up.

@BigVan
Copy link
Member Author

BigVan commented Jan 13, 2026

I released v1.4.0 manually...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Pull request is ok to run ci test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants