Half finished#7
Open
ljsikuade wants to merge 7 commits intoconstructorlabs:masterfrom
ljsikuade:master
Open
Conversation
| } | ||
| //Getting requests, setting them in state. Getting reviews, setting them in state. | ||
| componentDidMount() { | ||
| if (!localStorage.getItem("requests")) { |
Contributor
There was a problem hiding this comment.
It seems like too much work reading a value from localStorage, setting in localStorage and then reading it again. Why not read it and if it is not set then just a an empty array locally, instead of writing it to localStorage and reading it back.
| @@ -0,0 +1,24 @@ | |||
| import React from "react"; | |||
| //not sure I need the spread operator actually | |||
| function CurrentReviews({ reviews }, ...props) { | |||
Contributor
There was a problem hiding this comment.
not sure the spread operator helps here. you can either just use props object as a parameter or destructure it to extract all its values into own variables
| return ( | ||
| <main className="feed"> | ||
| <ul> | ||
| {requests ? ( |
Contributor
There was a problem hiding this comment.
when there are no requests it would be better to store it as an empty array and check the length property of the array to check if there is no data
Contributor
|
Good work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.