fix(ci): promise-returning function makes each test always eval true #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyyyaaa
changed the title
pyramation
reviewed
Dec 16, 2025
| BEGIN; | ||
|
|
||
| DROP ROLE administrator; | ||
| DO $revert$ |
Contributor
There was a problem hiding this comment.
this may be one of the things we don't want to revert and make a note of... not sure yet. could conflict w the test framework itself.
pyramation
requested changes
Dec 16, 2025
Contributor
pyramation
left a comment
pyramation
left a comment
There was a problem hiding this comment.
let's separate out different fixes into different PRs
| return result.success; | ||
| } | ||
|
|
||
| async function testPackage(packagePath, projectRoot, useDocker) { |
Contributor
There was a problem hiding this comment.
this is the only change that represents the title of the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.