fix(inquirerer): handle empty filteredOptions in checkbox and autocomplete #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(inquirerer): handle empty filteredOptions in checkbox and autocomplete
Summary
Fixes a crash when filtering options in checkbox/autocomplete prompts results in zero matches and the user presses arrow keys or space.
The bug: When typing a filter like "ve" that matches no options, pressing UP arrow would set
selectedIndex = filteredOptions.length - 1 = -1, causingCannot read properties of undefined (reading 'name')when accessingfilteredOptions[selectedIndex].The fix:
filteredOptionsis emptyupdateFilteredOptions()in checkbox to clamp indices when filtered results change (matching autocomplete's existing behavior)Review & Testing Checklist for Human
pgpm init, get to the extensions checkbox, type "ve" (or any filter with no matches), then press UP/DOWN arrows - should no longer crashNotes