Add setMaxLockDuration function to add-veLON-impplementation#65
Open
zeqing-guo wants to merge 10 commits intoadd-veLON-implementationfrom
Open
Add setMaxLockDuration function to add-veLON-impplementation#65zeqing-guo wants to merge 10 commits intoadd-veLON-implementationfrom
setMaxLockDuration function to add-veLON-impplementation#65zeqing-guo wants to merge 10 commits intoadd-veLON-implementationfrom
Conversation
Contributor
|
No particular issue at the first glance. However this function may consume lots of gas and perhaps exceed block limit? Need some test for gas consumption. |
Contributor
|
This one can be closed since we decided to use fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
setMaxLockDurationfunction toadd-veLON-impplementationbranch.Given the correctness and fairness, the code guarantees that if
old_power_A > old_power_B, then after updating themaxLockDurationwe havenew_power_A >= new_power_B.Code details are as follows:
lock.end > maxEndTime, we set thelock.end = maxEndTime. Then we update NFT's slope and biaslock.end <= maxEndTime, we update NFT's slope and bias directlyAfter updating every NFT's end, slope, and bias, we will update the global slope and bias.