Draft
Conversation
NIC619
commented
Jan 10, 2023
| bytes32 allowFillHash, | ||
| address recipient, | ||
| FillReceipt fillReceipt | ||
| bytes32 indexed orderHash, address indexed maker, address indexed taker, bytes32 allowFillHash, address recipient, FillReceipt fillReceipt |
Contributor
Author
There was a problem hiding this comment.
This creates different result from prettier and fmt: prettier has a problem but fmt does not, though this line does not exceed 160 characters...so I'm not sure why prettier is complaining.
Contributor
Author
There was a problem hiding this comment.
And this difference from fmt results in it updating many function and event declarations. This one is one of the many examples.
Contributor
Author
|
|
Contributor
|
Weird unwritten rules 😅 Overall I think prettier is a better fit to our preference for now. We can delay the foundry fmt integration and keep tracking its updates until it is better enough 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.