Skip to content

Conversation

@cmgsj
Copy link
Contributor

@cmgsj cmgsj commented Jan 31, 2025

@nicksnyder nicksnyder requested a review from emcfarlane January 31, 2025 20:43
@nicksnyder nicksnyder changed the title add support for protovalidate breaking changes Add support for protovalidate breaking changes Jan 31, 2025
Copy link
Collaborator

@emcfarlane emcfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! Small comment on the helper method.

@cmgsj
Copy link
Contributor Author

cmgsj commented Feb 1, 2025

Thanks for looking into this! Small comment on the helper method.

Hey @emcfarlane, just pushed a new commit resolving your comment. I was not aware of FieldPathString's existence, cool!

cmgsj added 2 commits January 31, 2025 19:09
Signed-off-by: cmgsj <cmgxcix@gmail.com>
Signed-off-by: cmgsj <cmgxcix@gmail.com>
Copy link
Collaborator

@emcfarlane emcfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emcfarlane emcfarlane merged commit 89db5fe into connectrpc:main Feb 1, 2025
7 checks passed
@cmgsj
Copy link
Contributor Author

cmgsj commented Feb 1, 2025

Thanks!

@emcfarlane when will this change be tagged/released?

@emcfarlane
Copy link
Collaborator

@cmgsj I'll look at some remaining updates and crafting a new release soon.

@emcfarlane
Copy link
Collaborator

@cmgsj changes have been released in 0.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants