Skip to content

Comments

CPBR-3041 replace docker compose with official docker sdk#205

Open
Hrithik Kulkarni (hk10111) wants to merge 17 commits intomasterfrom
replace-docker-compose
Open

CPBR-3041 replace docker compose with official docker sdk#205
Hrithik Kulkarni (hk10111) wants to merge 17 commits intomasterfrom
replace-docker-compose

Conversation

@hk10111
Copy link

@hk10111 Hrithik Kulkarni (hk10111) commented Sep 2, 2025

Change Description

Replaced docker-compose with a utility based on docker official's sdk for python

Testing

Tested with existing tests under test_docker_utils.py
cub and dub do not use the docker_utils so no impact on cub/dub
tested docker utils by using them in base image and running integration tests: https://semaphore.ci.confluent.io/workflows/dd6d367d-c356-4785-af8c-66973ef6d3fb/summary?pipeline_id=791ce31f-24f7-46f4-8503-b220f5b21c61

@hk10111 Hrithik Kulkarni (hk10111) marked this pull request as ready for review September 2, 2025 09:46
Copilot AI review requested due to automatic review settings September 2, 2025 09:46
@hk10111 Hrithik Kulkarni (hk10111) requested a review from a team as a code owner September 2, 2025 09:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the deprecated docker-compose Python library with the official Docker SDK, providing a modern implementation that maintains compatibility with Python 3.10+ while preserving the existing TestCluster interface.

  • Implements a complete replacement for docker-compose functionality using Docker SDK
  • Maintains backward compatibility with existing TestCluster interface
  • Updates all Docker API calls to use the modern Docker SDK patterns

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

File Description
confluent/docker_utils/compose_replacement.py New module implementing docker-compose functionality using Docker SDK with classes for config parsing, container management, and project orchestration
confluent/docker_utils/init.py Updates imports and refactors existing functions to use Docker SDK instead of deprecated compose library

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants