CPBR-3041 replace docker compose with official docker sdk#205
Open
Hrithik Kulkarni (hk10111) wants to merge 17 commits intomasterfrom
Open
CPBR-3041 replace docker compose with official docker sdk#205Hrithik Kulkarni (hk10111) wants to merge 17 commits intomasterfrom
Hrithik Kulkarni (hk10111) wants to merge 17 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the deprecated docker-compose Python library with the official Docker SDK, providing a modern implementation that maintains compatibility with Python 3.10+ while preserving the existing TestCluster interface.
- Implements a complete replacement for docker-compose functionality using Docker SDK
- Maintains backward compatibility with existing TestCluster interface
- Updates all Docker API calls to use the modern Docker SDK patterns
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| confluent/docker_utils/compose_replacement.py | New module implementing docker-compose functionality using Docker SDK with classes for config parsing, container management, and project orchestration |
| confluent/docker_utils/init.py | Updates imports and refactors existing functions to use Docker SDK instead of deprecated compose library |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Replaced docker-compose with a utility based on docker official's sdk for python
Testing
Tested with existing tests under test_docker_utils.py
cub and dub do not use the docker_utils so no impact on cub/dub
tested docker utils by using them in base image and running integration tests: https://semaphore.ci.confluent.io/workflows/dd6d367d-c356-4785-af8c-66973ef6d3fb/summary?pipeline_id=791ce31f-24f7-46f4-8503-b220f5b21c61