Open
Conversation
…en all the async lifecycle events are completed, and contains html with the latest updates from the completion of the async lifecycle methods
This was referenced Sep 21, 2022
Author
|
I propose to evaluate #30 instead of this one, because this solution was too rushed and doesn't supports certain scenarios at its current state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my proposed solution to this issue
it was independently developed from the other PR which I've noticed exist only after the facts :( sorry
This solution leverages on the already existing NextRender task without introducing additional synchronization mechanisms like semaphores.
As said in the above mentioned issue, the solution have a little of code duplication, there are easy way to fix it and i'm happy to apply the preferred one, let's just discuss it. options are:
Pros: easy code, Cons: the method should return more than one value => introduced a new return type with multiple properties or uses anonymous records.
Pros: avoid generation of new types, Cons: less simple code, force to return Task and in case ignore it when not needed
I probably prefer the first :)