remove logrus and add new interfaces for worker #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shaileshpadave
left a comment
shaileshpadave
left a comment
There was a problem hiding this comment.
Added few suggestions
sdk/main/main.go
Outdated
Comment on lines
124
to
153
| ////worker := worker.NewWorker("hello", ProcessBody) | ||
| // | ||
| ////taskClient := client.NewTaskClient(apiClient) | ||
| ////workerFn, _ := worker.GetWorker(ProcessBody) | ||
| ////_ = taskRunner.StartWorker2("hello", workerFn, 1, 1) | ||
| // | ||
| //opts := &client.TaskResourceApiBatchPollOpts{} | ||
| //tasks, _, err := taskClient.BatchPollTask(context.Background(), "hello", opts) | ||
| ////task := model.PolledTask{ | ||
| //// TaskType: "abcd", | ||
| //// InputData: "{}", | ||
| //// OutputData: "{}", | ||
| ////} | ||
| //if err != nil { | ||
| // fmt.Println("Got error ", err.Error()) | ||
| //} | ||
| //fmt.Println("Got", len(tasks)) | ||
|
|
||
| //for i := range tasks { | ||
| // fmt.Println("Task.Id", tasks[i].TaskId) | ||
| // res, err := te.Execute(&tasks[i]) | ||
| // if err != nil { | ||
| // fmt.Println("Error executing process body ", err.Error()) | ||
| // } else { | ||
| // fmt.Println("Response of process body", res) | ||
| // } | ||
| //} | ||
|
|
||
| //data, _ := json.Marshal(task.InputData) | ||
| //jsons := string(data) | ||
| //fmt.Println(jsons) |
Contributor
There was a problem hiding this comment.
Can we remove this commented code ?
Comment on lines
+60
to
+71
| func (task *PolledTask) ToValue(newValue any) (interface{}, error) { | ||
|
|
||
| bytes, err := task.InputData.MarshalJSON() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| err = json.Unmarshal(bytes, newValue) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return newValue, nil | ||
| } |
Contributor
There was a problem hiding this comment.
directly unmarshalling task.InputData into newValue
Suggested change
| func (task *PolledTask) ToValue(newValue any) (interface{}, error) { | |
| bytes, err := task.InputData.MarshalJSON() | |
| if err != nil { | |
| return nil, err | |
| } | |
| err = json.Unmarshal(bytes, newValue) | |
| if err != nil { | |
| return nil, err | |
| } | |
| return newValue, nil | |
| } | |
| func (task *PolledTask) ToValue(newValue interface{}) (interface{}, error) { | |
| err := json.Unmarshal(task.InputData, newValue) | |
| if err != nil { | |
| return nil, err | |
| } | |
| return newValue, nil | |
| } |
sdk/main/main.go
Outdated
| func authSettings() *settings.AuthenticationSettings { | ||
| key := "api_key_user_03" | ||
| secret := "api_key_user_03" | ||
| if key != "" && secret != "" { |
There was a problem hiding this comment.
Would we be replacing the key and secret somewhere, else can ignore the checks
sdk/main/main.go
Outdated
| func ProcessBody(body *Data) (*Data, error) { | ||
| if body == nil { | ||
| fmt.Println("Body is nil") | ||
| return nil, nil |
There was a problem hiding this comment.
Suggestion: error standardization maybe in some common file
| "encoding/xml" | ||
| "errors" | ||
| "fmt" | ||
| "github.com/conductor-sdk/conductor-go/sdk/log" |
There was a problem hiding this comment.
nitpick: linters could be introduced.
sdk/main/main.go
Outdated
| } | ||
|
|
||
| func ProcessBody2(task *model.Task) (interface{}, error) { | ||
| fmt.Println("executing", task.TaskId) |
There was a problem hiding this comment.
Suggestion: usage of logs instead of print with the correct log level to help in debugging later
sdk/main/main.go
Outdated
| "github.com/conductor-sdk/conductor-go/sdk/worker" | ||
| ) | ||
|
|
||
| type Restaurant struct { |
shaileshpadave
force-pushed
the
logger_and_worker
branch
12 times, most recently
from
231d007 to
1a8f74c
Compare
# Conflicts: # go.mod # go.sum # sdk/client/api_task_resource.go # sdk/log/logger.go # sdk/worker/task_runner.go
Co-authored-by: Shailesh Padave <shaileshpadave49@gmail.com>
Co-authored-by: Shailesh Padave <shaileshpadave49@gmail.com>
Co-authored-by: Shailesh Padave <shaileshpadave49@gmail.com>
shaileshpadave
force-pushed
the
logger_and_worker
branch
from
f783796 to
9370efa
Compare
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.17 as build | |||
| FROM golang:1.19 as build | |||
Contributor
There was a problem hiding this comment.
We should not upgrade to. 19 as Miguel mentioned in last pr that it might break few things, so i would say lets take this into another separate PR.
shaileshpadave
force-pushed
the
logger_and_worker
branch
from
9370efa to
bb8bab6
Compare
added 2 commits
May 23, 2025 18:39
shaileshpadave
force-pushed
the
logger_and_worker
branch
from
1d15228 to
8c2f12a
Compare
shaileshpadave
force-pushed
the
logger_and_worker
branch
from
8c2f12a to
13b6dae
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Fix in kitchensink:
When we return a TaskResult object from a worker function, the framework tries to extract the output from it, but this can cause serialization issues. The framework expects workers to return raw output data, which it then wraps in a TaskResult automatically.
Added tests: