Skip to content

Conversation

@kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Aug 16, 2024

Description

A few maintenance improvements:

  • converts metadata step (previously JS code) into GitHub Action Expressions
  • converts add signee step (previously JS code) into Python script
  • updates default input values based on upcoming move from conda/infrastructure to conda/cla

Depends on #203

Questions

  • Do we really need to be setting a cla-signed [bot] added once the contributor has signed the CLA label? It's the CLA check status that's actually being used to verify if a contributor has signed the CLA so is the cla-signed [bot] added once the contributor has signed the CLA label just noise?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 16, 2024
@kenodegard kenodegard changed the title Update check-cla Update check-cla action Aug 16, 2024
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Sometimes the login is a bot account that has the `[bot]` suffix. The brackets causes issues for branch names so using the raw user ID (and integer) is better.
@kenodegard kenodegard marked this pull request as ready for review January 10, 2025 15:56
@kenodegard kenodegard requested a review from a team as a code owner January 10, 2025 15:56
@conda-bot
Copy link
Contributor

conda-bot commented Jan 21, 2025

Warning

This is a test of the CLA system. Review for correctness but otherwise ignore this comment.

We require contributors to sign our Contributor License Agreement and we don't have one on file for @login (204).

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda-sandbox/cla#7), and ping the bot to refresh the PR.

Commands

Trigger actions by commenting on this PR:

  • @conda-bot check will check whether a CLA has been signed for this PR author

@kenodegard kenodegard force-pushed the check-cla branch 2 times, most recently from 067bdea to 8df586d Compare January 22, 2025 02:27
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA stale [bot] marked as stale due to inactivity

Projects

Status: 👀 In Review

Development

Successfully merging this pull request may close these issues.

4 participants