-
-
Notifications
You must be signed in to change notification settings - Fork 28
Fix #72: Add java artifacts #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix #72: Add java artifacts #207
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15041903025. Examine the logs at this URL for more detail. |
|
Do the linux builds take too much memory and trigger an OOM error? They are crashing after ~5 1/2 hours with no error message. |
|
I think so too. The way Linux builds failed looked to me like the one from OOM. The windows build on the other hand looks to me simpler. However, the bezel build recipe is using unzip internally. |
|
FWIW, it seems that the upstream does not support building/testing the Java artifacts on the Windows platform. |
|
What is the motivation for this PR?
I don't know how to use a larger machine in conda-forge/azure, maybe someone else in the @conda-forge/ray-packages team knows. I don't understand why it takes 5 hours to build ray. Locally the build takes ~20 minutes. |
|
Well... my main motivation is to run RayDP purely on conda environments.
It takes roughly the same amount of time (~20mins) on my local machine too. |
|
It takes forever because the azure devops runners have 2 cores.
I've put a request in for larger runners for this feedstock - conda-forge/admin-requests#1509 |
|
Close/reopen to use the larger linux runnuers |
|
The security policy on the larger machines requires that the commit come from someone approved to use them, so I pushed an empty commit in my name. |
a49edd5 to
b9f26d1
Compare
|
Empty commit only ran windows and macOS CI jobs, maybe rebasing is needed to get the linux ones to run? |
|
Not sure, maybe it has to do with the conflicts? IIRC, GHA won't run in |
|
I've fixed the conflicts. Let's see 🤞 |
|
We can see all the targets included in the CI/CD now. |
|
My bad. It's already run and green. Thanks you for updating @mattip |
Checklist
conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)I've tested the build only for Linux-64 Python3.12 environment so far.
Let me see how it goes on all the other platforms.