Skip to content

Allow commands to override the default --instance option #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KorvinSzanto wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow commands to override the default --instance option #38

KorvinSzanto wants to merge 2 commits into from

Conversation

@KorvinSzanto
Copy link
Member

@KorvinSzanto KorvinSzanto commented Sep 30, 2021

This resolves #31 by giving control of default extended options to the commands themselves.

@KorvinSzanto KorvinSzanto mentioned this pull request Sep 30, 2021
Closed
mlocati
mlocati reviewed Sep 30, 2021
View reviewed changes
@KorvinSzanto KorvinSzanto changed the title Allow commands to override the default options that get applied Allow commands to override the default --instance option Sep 30, 2021
@aembler
Copy link
Member

aembler commented Dec 13, 2022

Oh, I think I merged a different PR by @mlocati that does this. Can you confirm @mlocati ?

@mlocati
Copy link
Contributor

mlocati commented Dec 13, 2022

I absolutely don't remember, but IIRC Korvin's solution was better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mlocati mlocati mlocati left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Commands and --instance option

3 participants

@KorvinSzanto @aembler @mlocati