Adding new concepts #1504
Open
Adding new concepts #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@AnnikaTjuka, could you moderate this PR? |
Collaborator
|
Sure. @FredericBlum Would you review this PR since you were also involved in some of the discussions? |
Collaborator
|
If next week is sufficient, yes. I have some thesis stress right now. |
Collaborator
|
Sure, no worries. This has no urgency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"Additional information
This PR adds 22 new concept sets:
Further, some existing entries were remapped to the new concepts (RAISIN from GRAPE, from INK to SQUID).
Hidden characters in
conceptlists.tsv(in the description of MorenoMartinez-2012-360) and Vulic-2020-2244 were removed.Instances of "chalkboard" were added to 3084 BLACKBOARD.
A mapping of "flea" to 2241 WILD CAT was changed to 232 FLEA in Needham-1897-262.
A few previously missed mappings for 3025 BARN OR SHED and 4123 COMPETENCE were added.
Closes #1502.