Adding 18 new concepts and refining existing mappings #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…34, 1783 and 3704
Collaborator
Author
|
@AnnikaTjuka would you care to moderate this PR? Thank you! |
Collaborator
|
Sure. @chrzyki Would you have time to review this PR? |
Contributor
|
Yes, will do! Thank you for preparing this, @MiraAhmedovic! |
chrzyki
approved these changes
Sep 26, 2025
Contributor
chrzyki
left a comment
chrzyki
left a comment
There was a problem hiding this comment.
Looking good from my end, thank you again very much!
AnnikaTjuka
reviewed
Sep 26, 2025
Collaborator
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
There was a problem hiding this comment.
Just a few comments.
concepticondata/concepticon.tsv
Outdated
| 4105 FABRIC Clothing and grooming Material made by weaving, knitting, or otherwise producing cloth from fibers. Person/Thing | ||
| 4106 STIFF Sense perception Rigid or difficult to bend, move, or manipulate. Property | ||
| 4107 LIVELY Motion Full of energy, activity, or spirited movement; animated or vibrant. Property | ||
| 4107 LIVELY Motion Full of energy, activity, or spirited movement; animated or vibrant. Property |
Collaborator
There was a problem hiding this comment.
I'd use "Emotions and values" as a semantic field.
concepticondata/concepticon.tsv
Outdated
| 4117 CORRIDOR The house A long passage in a building that connects rooms or other spaces. Person/Thing | ||
| 4118 CONFIDENCE Emotions and values A feeling of trust or assurance in oneself, one’s abilities, or the reliability of someone or something. Person/Thing | ||
| 4119 REALITY Cognition The state of things as they actually exist, rather than as they may appear or be imagined. Person/Thing | ||
| 4120 REWARD Social and political relations Something given in recognition of effort, achievement, or service. Person/Thing |
Collaborator
There was a problem hiding this comment.
I'm not sure about this one, but maybe "Possession" as a semantic field would be better?
| Kornai-2018-1400-301 301 1195 come U 1446 COME jön venio przychodzić move, =AGT[near[after]] | ||
| Kornai-2018-1400-302 302 1240 comfort N kényelem commoditas wygoda pleasure, rest | ||
| Kornai-2018-1400-303 303 2626 comfort N vigasz solacium pocieszenie good FOR soul | ||
| Kornai-2018-1400-302 302 1240 comfort N 4112 COMFORT kényelem commoditas wygoda pleasure, rest |
Collaborator
There was a problem hiding this comment.
These seem to be two different concepts. Could you check the other languages to check which one fits best?
Collaborator
Author
There was a problem hiding this comment.
Translation wise, both Hungarian and Polish seem to fit the concept ("comfort, convenience, ease"). The outlier is Latin I'd say, which could be closer to "commodity, convenience, suitability, advantage".
Any preferences for how this should be handled?
Collaborator
There was a problem hiding this comment.
I see. Then we can leave it as is.
| Zalizniak-2024-4583-1914 1914 mouth (of a river) mouth (of a river) 1701 RIVER MOUTH end of a river out of which water flows into a sea or other large body of water Natural objects [] "[{""ID"": ""Zalizniak-2024-4583-1913"", ""NAME"": ""mouth"", ""Polysemy"": 8, ""Derivation"": 1, ""PolysemyByFamily"": 4, ""DerivationByFamily"": 1, ""Polysemy_Lexemes"": [""3292"", ""3294"", ""3296"", ""3298"", ""3299"", ""3300"", ""3301"", ""3302""], ""Derivation_Lexemes"": [""3295""], ""Polysemy_Shifts"": [""shift0477"", ""shift0477"", ""shift0477"", ""shift0477"", ""shift0477"", ""shift0477"", ""shift0477"", ""shift0477""], ""Derivation_Shifts"": [""shift0477""], ""Polysemy_Families"": [""Altaic"", ""Uralic"", ""Indo-European"", ""Indo-European"", ""Sino-Tibetan"", ""Indo-European"", ""Indo-European"", ""Altaic""], ""Derivation_Families"": [""Indo-European""]}, {""ID"": ""Zalizniak-2024-4583-3024"", ""NAME"": ""throat"", ""Polysemy"": 2, ""Derivation"": 0, ""PolysemyByFamily"": 2, ""DerivationByFamily"": 0, ""Polysemy_Lexemes"": [""3509"", ""3510""], ""Derivation_Lexemes"": [], ""Polysemy_Shifts"": [""shift0508"", ""shift0508""], ""Derivation_Shifts"": [], ""Polysemy_Families"": [""Altaic"", ""Chukotko-Kamchatkan""], ""Derivation_Families"": []}, {""ID"": ""Zalizniak-2024-4583-1117"", ""NAME"": ""foot/leg"", ""Polysemy"": 1, ""Derivation"": 0, ""PolysemyByFamily"": 1, ""DerivationByFamily"": 0, ""Polysemy_Lexemes"": [""3563""], ""Derivation_Lexemes"": [], ""Polysemy_Shifts"": [""shift0517""], ""Derivation_Shifts"": [], ""Polysemy_Families"": [""Altaic""], ""Derivation_Families"": []}, {""ID"": ""Zalizniak-2024-4583-1934"", ""NAME"": ""muzzle"", ""Polysemy"": 1, ""Derivation"": 0, ""PolysemyByFamily"": 1, ""DerivationByFamily"": 0, ""Polysemy_Lexemes"": [""11063""], ""Derivation_Lexemes"": [], ""Polysemy_Shifts"": [""shift1561""], ""Derivation_Shifts"": [], ""Polysemy_Families"": [""Northeast Caucasian""], ""Derivation_Families"": []}, {""ID"": ""Zalizniak-2024-4583-826"", ""NAME"": ""door"", ""Polysemy"": 1, ""Derivation"": 0, ""PolysemyByFamily"": 1, ""DerivationByFamily"": 0, ""Polysemy_Lexemes"": [""13675""], ""Derivation_Lexemes"": [], ""Polysemy_Shifts"": [""shift2177""], ""Derivation_Shifts"": [], ""Polysemy_Families"": [""Atlantic\u2013Congo""], ""Derivation_Families"": []}, {""ID"": ""Zalizniak-2024-4583-2068"", ""NAME"": ""opening, hole"", ""Polysemy"": 1, ""Derivation"": 0, ""PolysemyByFamily"": 1, ""DerivationByFamily"": 0, ""Polysemy_Lexemes"": [""13892""], ""Derivation_Lexemes"": [], ""Polysemy_Shifts"": [""shift2227""], ""Derivation_Shifts"": [], ""Polysemy_Families"": [""Indo-European""], ""Derivation_Families"": []}, {""ID"": ""Zalizniak-2024-4583-706"", ""NAME"": ""crossroads"", ""Polysemy"": 1, ""Derivation"": 0, ""PolysemyByFamily"": 1, ""DerivationByFamily"": 0, ""Polysemy_Lexemes"": [""19902""], ""Derivation_Lexemes"": [], ""Polysemy_Shifts"": [""shift4021""], ""Derivation_Shifts"": [], ""Polysemy_Families"": [""Uralic""], ""Derivation_Families"": []}]" | ||
| Zalizniak-2024-4583-1915 1915 move (board games) move (board games) N/a [] [] | ||
| Zalizniak-2024-4583-1916 1916 mucus, slime mucus, slime slippery secretion from the lining of the mucous membranes or a mucus-like substance which exudes from the bodies of certain animals, such as snails or slugs N/a [] "[{""ID"": ""Zalizniak-2024-4583-2502"", ""NAME"": ""sapwood, alburnum"", ""Polysemy"": 1, ""Derivation"": 0, ""PolysemyByFamily"": 1, ""DerivationByFamily"": 0, ""Polysemy_Lexemes"": [""30057""], ""Derivation_Lexemes"": [], ""Polysemy_Shifts"": [""shift7953""], ""Derivation_Shifts"": [], ""Polysemy_Families"": [""Altaic""], ""Derivation_Families"": []}]" | ||
| Zalizniak-2024-4583-1916 1916 mucus, slime mucus, slime 4121 SLIME slippery secretion from the lining of the mucous membranes or a mucus-like substance which exudes from the bodies of certain animals, such as snails or slugs N/a [] "[{""ID"": ""Zalizniak-2024-4583-2502"", ""NAME"": ""sapwood, alburnum"", ""Polysemy"": 1, ""Derivation"": 0, ""PolysemyByFamily"": 1, ""DerivationByFamily"": 0, ""Polysemy_Lexemes"": [""30057""], ""Derivation_Lexemes"": [], ""Polysemy_Shifts"": [""shift7953""], ""Derivation_Shifts"": [], ""Polysemy_Families"": [""Altaic""], ""Derivation_Families"": []}]" |
Collaborator
There was a problem hiding this comment.
We have a concept MUCUS. Was this already mapped in the list?
Collaborator
Author
There was a problem hiding this comment.
I found the concept 208 NASAL MUSUCS (SNOT) which was not mapped to Zalizniak-2024-4583-1916 yet. 208, however, also seems to overlap with 3061 PHLEGM to some extent.
Collaborator
There was a problem hiding this comment.
Ah, sorry, I didn't read the description "exudes from the bodies of certain animals, such as snails or slugs". Then the mapping is correct, but we should maybe add this to the description of the concept, too.
Collaborator
Author
|
@AnnikaTjuka do you wanna take another look before I merge? |
AnnikaTjuka
approved these changes
Sep 29, 2025
Collaborator
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
There was a problem hiding this comment.
Looks good, many thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"Additional information
Adding 18 new concepts:
Further, existing mappings were refined:
25 DIRT: Huang-1992-1820-160 remapped to4124 FILTH. Closes #1487.134 FAULT: DellaRosa-2010-417-26, Ferre-2022-160-31, Hale-1973-1798-1185, Miklashevsky-2018-506-50 remapped to4125 GUILT. Closes #1491.1783 PAIN: Huang-1992-1820-688 remapped to4122 AGONY.3704 ODOR (SMELL): Oliveira-2014-517-335 unmapped. Closes #1489.