Conversation
Added game image
memsharded
left a comment
memsharded
left a comment
There was a problem hiding this comment.
It is looking good so far.
There are some typos, most don't matter, but the bindigs in the path, better fix it.
| tools.build:sharedlinkflags=['-sALLOW_MEMORY_GROWTH=1'] | ||
|
|
||
| # Set Ninja as default generator as it is faster and will sove issues on Windows | ||
| tools.cmake.cmaketoolchain:generator=Ninja |
There was a problem hiding this comment.
What is the default generator for emcc? Unix/MinGW Makefiles?
| @@ -0,0 +1,39 @@ | |||
| # Note: this profile uses emsdk package from Conan Center Index | |||
There was a problem hiding this comment.
Call this profile emcc_base or something like that?
| deps.generate() | ||
|
|
||
| tc = CMakeToolchain(self) | ||
| tc.extra_exelinkflags.append( |
There was a problem hiding this comment.
Same as above, either a validate() or the flags go to the profile?
… + emcc) (#18432) Changelog: Feature: Added first class citizen emscripten support (new wasm64 architecture + emcc) Docs: conan-io/docs#4115 Examples2: conan-io/examples2#184 This PR adds updated support to `wasm` (32 bits) and `asm.js` and introduces new architecture `wasm64`.
.github/workflows/ros-tests.yml
Outdated
| # - name: Update ROS signing key (per ROS migration guide) | ||
| # run: | | ||
| # sudo rm /usr/share/keyrings/ros2-latest-archive-keyring.gpg | ||
| # sudo curl -sSL https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -o /usr/share/keyrings/ros2-latest-archive-keyring.gpg |
There was a problem hiding this comment.
Isn't this necessary any more? Why is this commented?
.github/workflows/ros-tests.yml
Outdated
| run: | | ||
| sudo rm /usr/share/keyrings/ros2-latest-archive-keyring.gpg | ||
| sudo curl -sSL https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -o /usr/share/keyrings/ros2-latest-archive-keyring.gpg | ||
| # - name: Update ROS signing key (per ROS migration guide) |
There was a problem hiding this comment.
this was already fixed in main branch, could you sync your branch?
| import os | ||
| from test.examples_tools import run | ||
|
|
||
| run('conan config install https://github.com/perseoGI/conan-toolchains.git -sf conan_config --args "-b pgi/new/emsdk"') |
There was a problem hiding this comment.
What is exactly being config-installed from your fork of the conan-toolchains? Does that repo contain configuration too? Sounds not possible for the examples repo, this should be more straightforward.
| # https://github.com/emscripten-core/emscripten/blob/main/ChangeLog.md#407---041525 | ||
| tc.extra_exelinkflags.append( | ||
| "-sEXPORTED_FUNCTIONS=['_malloc','_free'] \ | ||
| -sEXPORTED_RUNTIME_METHODS=['ccall','cwrap','getValue','setValue','HEAPF32'] \ |
There was a problem hiding this comment.
I am still a bit surprised of seeing these flags in recipes by default. Shouldn't flags belong to user toolchains somehow and not Conan? Where does users that use Emscripten put these flags if not using Conan?
| import platform | ||
| from test.examples_tools import chdir, run | ||
|
|
||
| run('conan config install https://github.com/perseoGI/conan-toolchains.git -sf conan_config --args "-b pgi/new/emsdk"') |
3 participants
No description provided.