feat: add migration for schedule table foreign key constraint updates#13
Merged
abielzulio merged 1 commit intomainfrom Mar 30, 2025
Merged
feat: add migration for schedule table foreign key constraint updates#13abielzulio merged 1 commit intomainfrom
abielzulio merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a migration to update the foreign key constraints for the schedule table.
- Enforces non-nullability on station_origin_id
- Changes the onDelete behavior for station_origin_id from "set null" to "cascade"
Files not reviewed (3)
- drizzle/migrations/0008_wooden_purple_man.sql: Language not supported
- drizzle/migrations/meta/0008_snapshot.json: Language not supported
- drizzle/migrations/meta/_journal.json: Language not supported
Comments suppressed due to low confidence (2)
src/db/schema/schedule.table.ts:34
- Verify that enforcing .notNull() on station_origin_id is intended given that station_destination_id remains nullable. Ensure that this change aligns with the expected business logic.
.notNull()
src/db/schema/schedule.table.ts:36
- Changing the onDelete behavior from 'set null' to 'cascade' can lead to unintended cascading deletions. Confirm that this change is in line with the overall referential integrity requirements.
onDelete: "cascade"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.