Skip to content

#1076 - Egen komponent for Card i designsystemet#54

Draft
rebalv wants to merge 17 commits intomainfrom
1067-egen-card-komponent-i-designsystemet
Draft

#1076 - Egen komponent for Card i designsystemet#54
rebalv wants to merge 17 commits intomainfrom
1067-egen-card-komponent-i-designsystemet

Conversation

@rebalv
Copy link
Contributor

@rebalv rebalv commented Oct 22, 2025

✨ Endringer i denne PRen

  • I denne PRen har jeg laget en veldig enkel komponent for Card med image, title, href og slots for subtitle og other.
  • Det er tatt utgagnspunkt i stylingen fra EventCard i chubben-arrangementer-frontend
  • Inkluderer nye css-filer for de ulike typografiklassene

@rebalv rebalv marked this pull request as draft October 22, 2025 09:35
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@rebalv rebalv requested a review from matpbk October 22, 2025 11:34
@matpbk
Copy link
Contributor

matpbk commented Oct 23, 2025

Vi bruker markdown for dokumentasjon, du kan se i de andre komponentene at vi har en "Overview.mdx" fil.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@rebalv rebalv requested a review from eTallang October 30, 2025 08:50
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net


return this.href
? html`
<a href="${this.href}" class="card clickable">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vi burde egentlig unngå bake in <a tags i komponentene våre fordi mange rammeverk har sine egne Lenke komponenter for å fungere som en SPA. En vanlig <a tag vil gi en full refreshe og navigasjon på siden. Det blir også problemer med skjermleser hvis card inneholder knapper i tillegg.

Så tenker at om man heller lar konsumenten av card f.eks wrappe den i en Lenke komponent selv hvis det skal brukes som lenke så vil det alltid funke :)

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants