Skip to content

Conversation

@shahrukh-compuco
Copy link
Contributor

@shahrukh-compuco shahrukh-compuco commented Dec 31, 2025

Overview

This PR fixes the result set while exporting a batch to CSV that contains credit note allocation transactions, we recently started showing allocation transactions in the batch creation screen that were needed for sage50 export but for CSV export we dont need these allocation transactions in exported file so this PR fixes the query for CSV export to remove the allocation transaction records as they were coming out as incomplete in CSV export.

@shahrukh-compuco
Copy link
Contributor Author

@codex review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an issue where credit note allocation transactions were incorrectly included in CSV batch exports. The fix adds a filter to exclude allocation transactions (which lack associated financial transaction contributions) from the CSV export query, while keeping them available for Sage50 exports where they are required.

Key Changes:

  • Modified the SQL WHERE clause to filter out allocation transactions by checking for non-null eftc.id values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@shahrukh-compuco shahrukh-compuco merged commit 71c43c5 into master Jan 6, 2026
2 checks passed
@shahrukh-compuco shahrukh-compuco deleted the comcl-1326-fix-transaction-export branch January 6, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants