added test case for s3_bucket_default_encryption#317
Open
Khushi-Kalantri-Comprinno wants to merge 1 commit intocomprinnotech:testcases_devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR adds comprehensive test coverage for the s3_bucket_default_encryption check.
This PR introduces a complete and corrected test suite for the s3_bucket_default_encryption check, covering the following scenarios:
-KMS encryption enabled: Bucket uses aws:kms with a valid key.
-AES256 encryption enabled: Bucket uses AES256 (SSE-S3).
-No default encryption: Bucket has no encryption configuration.
-Unknown ClientError: Unexpected client exception from get_bucket_encryption.
-Endpoint/network error: Simulates BotoCoreError (e.g., network issue).
-No buckets found: Verifies behavior when the S3 account is empty.
###Checklist
-The code is fully covered by unit tests, with each execution path validated.
-All new code and test logic follow the Google Python Style Guide.
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.