added test case for test_vpc_flowlogs_enable_logging#312
Open
Khushi-Kalantri-Comprinno wants to merge 2 commits intocomprinnotech:testcases_devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Adding a new test case to verify whether VPC Flow Logs are enabled for all VPCs as part of the AWS security best practices.
Fixes incorrect or missing coverage for
vpc_flowlogs_enable_logging.Description
Implemented
test_vpc_flowlogs_enable_logging.pyunderlibrary/aws/testcases/vpc/Added tests for scenarios:
UnauthorizedOperation)Uses
MagicMockto simulateboto3EC2 client responsesAligns structure and metadata with
iam_password_policy_lowercasetest format for consistencyChecklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.