Check acl_bidirectional_traffic_restriction_check added#287
Open
prajwal-choudhari-comprinno wants to merge 3 commits intocomprinnotech:testcases_devfrom
Conversation
| assert report.status == CheckStatus.FAILED | ||
| assert report.resource_ids_status[0].summary is not None | ||
| # Since there's no ACL id, no ARN assertion here | ||
| assert "Error fetching Network ACLs" in report.resource_ids_status[0].summary |
Contributor
There was a problem hiding this comment.
Test Mixed Rule Sets
Add a test for an ACL that has both secure and overly permissive entries to validate correct classification.
Validate Multiple ACLs in One Response
Add a case where multiple ACLs with varying compliance statuses are returned to verify report aggregation and final check status logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Adding unit tests for
acl_bidirectional_traffic_restriction_checkto improve test coverage and ensure reliability of the ACL security check.Description
Implemented test cases to validate different ACL configurations:
Used
MagicMockto simulateboto3client responses.No new dependencies introduced.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.