Skip to content

Conversation

@bongjinkoo
Copy link
Collaborator

Description

This is for testing the issue regarding the issue with installing jupyter in the conda environment on the GitHub runner,
mentioned on PR #75.

Issue

#86

@bongjinkoo bongjinkoo self-assigned this May 18, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #90 (111543b) into master (aa08d56) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files           5        5           
  Lines         223      223           
=======================================
  Hits          220      220           
  Misses          3        3           
Impacted Files Coverage Δ
ioSPI/datasets.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa08d56...111543b. Read the comment docs.

@bongjinkoo
Copy link
Collaborator Author

I searched online why this happens but couldn't find any useful information. Thus, I just made jupyter installed with pip instead of conda, which seems to solve the problem.

@bongjinkoo bongjinkoo requested a review from ninamiolane May 18, 2022 22:07
Copy link
Contributor

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@ninamiolane ninamiolane merged commit 0ee2cb5 into master May 18, 2022
@ninamiolane ninamiolane deleted the 86-conda-jupyter-install-issue branch May 18, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants