-
-
Notifications
You must be signed in to change notification settings - Fork 304
ci: add link checker #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ci: add link checker #1696
Conversation
7315679 to
717960b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1696 +/- ##
==========================================
+ Coverage 97.33% 97.88% +0.55%
==========================================
Files 42 60 +18
Lines 2104 2605 +501
==========================================
+ Hits 2048 2550 +502
+ Misses 56 55 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b95bbe6 to
59eb5bf
Compare
|
@woile @Lee-W would you like to create issue form when broken link is found? If we want to automatically create issues for broken links, we may need to adjust our repo settings Failed run: https://github.com/commitizen-tools/commitizen/actions/runs/19989102721/job/57327236001 |
651fb63 to
aaa410b
Compare
.github/workflows/links.yml
Outdated
| args: . --exclude-path "tests" | ||
| fail: false | ||
|
|
||
| # - name: Create or Update PR Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probbaly use it to create an issue instead of a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, let's start with an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I was thinking about the behavior of the pipeline when the link checker fails (non-empty error list) on a documentation PR.
.github/workflows/links.yml
Outdated
| args: . --exclude-path "tests" | ||
| fail: false | ||
|
|
||
| # - name: Create or Update PR Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probbaly use it to create an issue instead of a PR?
b623823 to
6368980
Compare
6368980 to
7e5d8ae
Compare
Let's try this.
Closes #1691