-
Notifications
You must be signed in to change notification settings - Fork 22
Add the ability to dismiss the keyboard by tapping outside of the text area #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
polemarkh
wants to merge
7
commits into
commetchat:main
Choose a base branch
from
polemarkh:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ca7503b
Added the ability to dismiss the keyboard
polemarkh ab3287b
Merge branch 'commetchat:main' into main
polemarkh 1f05f37
Merge branch 'commetchat:main' into main
polemarkh d1c7db6
With a hardware keyboard, shift-return will now enter a newline witho…
polemarkh 6b4bd14
Merge branch 'commetchat:main' into main
polemarkh 6dc54fc
Merge branch 'commetchat:main' into main
polemarkh 3eda7c5
Merge pull request #4 from commetchat/main
polemarkh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import 'package:flutter/material.dart'; | ||
|
|
||
| class DismissKeyboard extends StatelessWidget { | ||
| final Widget child; | ||
| const DismissKeyboard({Key? key, required this.child}) : super(key: key); | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| return GestureDetector( | ||
| onTap: () { | ||
| FocusScopeNode currentFocus = FocusScope.of(context); | ||
| if (!currentFocus.hasPrimaryFocus && | ||
| currentFocus.focusedChild != null) { | ||
| FocusManager.instance.primaryFocus?.unfocus(); | ||
| } | ||
| }, | ||
| child: child, | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code shouldn't be necessary, and the desired behavior was already implemented previously. It seems that the recent change setting
keyboardType: TextInputType.texton the TextField prevented the behaviour, which I am correcting in #435Please remove