Update variables for mainnet/testnet and download chain information f… #1
Conversation
marcotradenet
left a comment
marcotradenet
left a comment
There was a problem hiding this comment.
Please. Check review.
README.md
Outdated
| 2. Proceed to run the `main` playbook: | ||
| ```bash | ||
| ansible-playbook -i hosts.ini main/commercio.yml | ||
| ansible-playbook -i .hosts.ini main/commercio.yml |
There was a problem hiding this comment.
This is and error: in the .gitignore file hosts.ini is correctly excluded from the GitHub repository. .hosts.ini is a template
main/group_vars/all
Outdated
| slack_hook: "" | ||
| trust_rpc1: "rpc-mainnet.commercio.network:80" | ||
| trust_rpc2: "rpc2-mainnet.commercio.network:80" | ||
| trust_rpc2: "rpc2-mainnet.commercio.network:80" |
There was a problem hiding this comment.
The rpcs data should be customizable selecting the chain. It should be explain in the README or better download from chains repository. You can add some variable if you want.
| # For Cosmos SDK-based chains, trust_period should usually be about 2/3 of the unbonding time (~2 | ||
| # weeks) during which they can be financially punished (slashed) for misbehavior. | ||
| rpc_servers = "157.230.110.18:26657,46.101.146.48:26657" | ||
| rpc_servers = "{{ trust_rpc1 }},{{ trust_rpc2 }}" |
There was a problem hiding this comment.
You can create a unique variable before use it: if one day we add a rpc server it could be useful
| @@ -1,8 +1,25 @@ | |||
| - name: Get data from URL | |||
| uri: | |||
| url: "https://raw.githubusercontent.com/lmc-mint/chains/master/{{ chain_id }}/.data.json" | |||
There was a problem hiding this comment.
This is a point to your fork. It should be the official repository. You can handle the error or put the path of the data in a variable.
main/group_vars/all
Outdated
| slack_hook: "" | ||
| trust_rpc1: "rpc-mainnet.commercio.network:80" | ||
| trust_rpc2: "rpc2-mainnet.commercio.network:80" | ||
| rpc_servers: "{{ trust_rpc1 }},{{ trust_rpc2 }}" |
There was a problem hiding this comment.
I think this can't work: trust_rpc1 and trust_rpc2 get the value in a subsequent task
* update playbook and variables structure
* update playbook and readme
2 participants
In order to use the playbook for mainnet and testnet , we need to :