Skip to content

Harm meier im 1154 template issues handle ResourceCreated #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harm-meijer merged 2 commits into from
May 6, 2025
Merged

Harm meier im 1154 template issues handle ResourceCreated #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea7f1f6
fix: default for scope is undefined
harm-meijer Mar 26, 2025
aac1123
fix: handle resource created
harm-meijer Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions application-templates/javascript/event/src/controllers/event.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ export const post = async (request, response) => {

if (decodedData) {
const jsonData = JSON.parse(decodedData);
//CoCo sending message to indicate the resource was created, does not need processing
if ('ResourceCreated' === jsonData.notificationType) {
throw new CustomError(
202,
`Incoming message is about subscription resource creation. Skip handling the message.`
);
}

customerId = jsonData.customer.id;
}
Expand Down
2 changes: 1 addition & 1 deletion application-templates/javascript/event/src/middleware/auth.middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ export const authMiddlewareOptions = {
clientId: readConfiguration().clientId,
clientSecret: readConfiguration().clientSecret,
},
scopes: [readConfiguration().scope ? readConfiguration().scope : 'default'],
scopes: readConfiguration().scope ? [readConfiguration().scope] : undefined,
};
2 changes: 1 addition & 1 deletion application-templates/javascript/job/src/middleware/auth.middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ export const createAuthMiddlewareOptions = () => ({
clientId: readConfiguration().clientId,
clientSecret: readConfiguration().clientSecret,
},
scopes: [readConfiguration().scope ? readConfiguration().scope : 'default'],
scopes: readConfiguration().scope ? [readConfiguration().scope] : undefined,
});
2 changes: 1 addition & 1 deletion application-templates/javascript/service/src/middleware/auth.middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ export const authMiddlewareOptions = {
clientId: readConfiguration().clientId,
clientSecret: readConfiguration().clientSecret,
},
scopes: [readConfiguration().scope ? readConfiguration().scope : 'default'],
scopes: readConfiguration().scope ? [readConfiguration().scope] : undefined,
};
7 changes: 7 additions & 0 deletions application-templates/typescript/event/src/controllers/event.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ export const post = async (request: Request, response: Response) => {

if (decodedData) {
const jsonData = JSON.parse(decodedData);
//CoCo sending message to indicate the resource was created, does not need processing
if ('ResourceCreated' === jsonData.notificationType) {
throw new CustomError(
202,
`Incoming message is about subscription resource creation. Skip handling the message.`
);
}

customerId = jsonData.customer.id;
}
Expand Down
8 changes: 3 additions & 5 deletions application-templates/typescript/job/src/middleware/auth.middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ export const createAuthMiddlewareOptions: () => AuthMiddlewareOptions = () => ({
clientId: readConfiguration().clientId,
clientSecret: readConfiguration().clientSecret,
},
scopes: [
(readConfiguration().scope
? readConfiguration().scope
: 'default') as string,
],
scopes: readConfiguration().scope
? [readConfiguration().scope as string]
: undefined,
});
8 changes: 3 additions & 5 deletions application-templates/typescript/service/src/middleware/auth.middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ export const authMiddlewareOptions: AuthMiddlewareOptions = {
clientId: readConfiguration().clientId,
clientSecret: readConfiguration().clientSecret,
},
scopes: [
readConfiguration().scope
? (readConfiguration().scope as string)
: 'default',
],
scopes: readConfiguration().scope
? [readConfiguration().scope as string]
: undefined,
};
Loading