Add support to order token and replace eslint with biome #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for replacing the :token placeholder in organization configuration URLs and updates the linting setup by replacing ESLint with Biome.
- Adds a new token property to configuration and enhances placeholder replacement logic
- Updates type definitions and refactors import/quote styles in multiple files
- Updates and adds test cases and benchmarks, and revises project configuration (package.json and biome.json)
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/organization-config/src/testHelper.ts | Introduces default and override configurations with URL templates |
| packages/organization-config/src/schema/types.ts | Updates type definitions formatting and semicolon usage |
| packages/organization-config/src/schema/generate.js | Refactors import syntax and quote styles in schema generation |
| packages/organization-config/src/index.ts | Adjusts exports from getMfeConfig modules |
| packages/organization-config/src/getMfeConfig.ts | Adds support for a new token parameter in placeholder replacement |
| packages/organization-config/src/getMfeConfig.test.ts | Updates tests to verify token replacement and other URL placeholders |
| packages/organization-config/src/getMfeConfig.benchmark.ts | Benchmarks merging utilities with updated configuration |
| packages/organization-config/package.json | Replaces ESLint with Biome and bumps dependency versions |
| packages/organization-config/biome.json | Adds the new Biome configuration file |
| }, | ||
| { | ||
| value: "US", | ||
| label: "Unites States of America", |
There was a problem hiding this comment.
The label for the US appears to be misspelled ('Unites' should be 'United'). Please correct it for clarity.
Suggested change
| label: "Unites States of America", | |
| label: "United States of America", |
Comment on lines
+8
to
+31
| export type Url = string | ||
| /** | ||
| * The international 2-letter country code as defined by the ISO 3166-1 standard. | ||
| */ | ||
| export type CountryCode = string; | ||
| export type CountryCode = string | ||
| /** | ||
| * List of billing countries by identifier and label. | ||
| */ | ||
| export type StateCountry = { | ||
| value: CountryCode; | ||
| value: CountryCode | ||
| /** | ||
| * Name of the country. | ||
| */ | ||
| label: string; | ||
| }[]; | ||
| label: string | ||
| }[] | ||
| /** | ||
| * List of shipping countries by identifier and label. | ||
| */ | ||
| export type StateCountry1 = { | ||
| value: CountryCode; | ||
| value: CountryCode | ||
| /** | ||
| * Name of the country. | ||
| */ | ||
| label: string; | ||
| }[]; | ||
| label: string |
There was a problem hiding this comment.
[nitpick] Consider using consistent semicolon usage (or omit them consistently) in type declarations to match the rest of the codebase's style.
malessani
force-pushed
the
feat/add-support-to-order-token
branch
from
57e3391 to
968b424
Compare
malessani
force-pushed
the
feat/add-support-to-order-token
branch
from
968b424 to
af00be8
Compare
gciotola
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
What I did
How to test
Checklist