This repository was archived by the owner on Mar 23, 2021. It is now read-only.
Conversation
tcharding
approved these changes
Aug 20, 2020
thomaseizinger
force-pushed
the
infer-dai-address
branch
from
84e1db4 to
e9ad2c5
Compare
Contributor
Author
|
@D4nte and @tcharding I pushed three follow-up commits that were necessary to fix the e2e tests and also to include the ropsten address :) |
thomaseizinger
force-pushed
the
infer-dai-address
branch
from
7fd223b to
c0a7134
Compare
rishflab
approved these changes
Aug 21, 2020
This introduces the ethereum::Address type into our config::File struct. Unfortunately, this opens a can of worms with a bug in the serde-hex library. See [0] for more details. We work around this by removing the dependency on serde-hex from our Ethereum deserialization code and instead hand-roll everything for our usecase. This also has the advantage that we can now again just use our structs directly in the route handlers of warp instead of serde_json::Value. See [1] for more on this. [0]: fspmarshall/serde-hex#8 [1]: #2405
With the addition of the [tokens] section, cnd fails to start up in `--dev` mode if the config file provided doesn't define a contract address.
D4nte
approved these changes
Aug 21, 2020
thomaseizinger
force-pushed
the
infer-dai-address
branch
from
c0a7134 to
48e1060
Compare
Contributor
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are going to use this to avoid including the token contract address in the orders that we are sending around.
This introduces the ethereum::Address type into our config::File
struct. Unfortunately, this opens a can of worms with a bug in
the serde-hex library. See 0 for more details.
We work around this by removing the dependency on serde-hex from our
Ethereum deserialization code and instead hand-roll everything for
our usecase.
This also has the advantage that we can now again just use our structs
directly in the route handlers of warp instead of serde_json::Value.
See 1 for more on this.