Quick-n-dirty creation of a submodule for packing up dojo sources.#1
Open
ddumont wants to merge 1 commit intocometd:masterfrom
Open
Quick-n-dirty creation of a submodule for packing up dojo sources.#1ddumont wants to merge 1 commit intocometd:masterfrom
ddumont wants to merge 1 commit intocometd:masterfrom
Conversation
Member
|
Thanks for the contribution. I'll have a look at this in detail probably next week.... however my first thought was that I was intending to have the source as an extra artefact produced from the dojo module, rather than as an entirely new module. But it may be that you have the secret sauce in your pom that will enable this |
Author
|
ok I see. Perhaps we could download both artifacts from dojo and extract them both and package them both in the same dojo build. I thought those wanting to do the maven build manually might want to do one or the other. At which point you would use profiles... I wasn't sure what you wanted to do and thought a new submodule might be more straightforward, but if you rather another way, please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example output generates:
dojo-src-1.9.2-SNAPSHOT.tar.bz2
dojo-src-1.9.2-SNAPSHOT.tar.gz
dojo-src-1.9.2-SNAPSHOT.zip